[Monitoring] New platform migration - Server shim#46507
Merged
chrisronline merged 9 commits intoelastic:masterfrom Oct 11, 2019
Merged
[Monitoring] New platform migration - Server shim#46507chrisronline merged 9 commits intoelastic:masterfrom
chrisronline merged 9 commits intoelastic:masterfrom
Conversation
chrisronline
added
Team:Monitoring
Contributor
|
Pinging @elastic/stack-monitoring |
Contributor
💔 Build Failed |
8 tasks
Contributor
💚 Build Succeeded |
13 tasks
Contributor
💚 Build Succeeded |
Contributor
Author
|
@igoristic @restrry I think this is ready for a first round of review |
chrisronline
added
release_note:skip
igoristic
reviewed
Oct 8, 2019
igoristic
reviewed
Oct 8, 2019
igoristic
approved these changes
Oct 8, 2019
Contributor
igoristic
left a comment
igoristic
left a comment
There was a problem hiding this comment.
Everything works as expected. Great job! 👍
mshustov
approved these changes
Oct 9, 2019
Contributor
💚 Build Succeeded |
chrisronline
added a commit
to chrisronline/kibana
that referenced
this pull request
Oct 11, 2019
* WIP * More NP refactoring * Hook up infra postInit logic * Fix broken tests * Cleanup
chrisronline
added a commit
to chrisronline/kibana
that referenced
this pull request
Oct 11, 2019
* WIP * More NP refactoring * Hook up infra postInit logic * Fix broken tests * Cleanup
chrisronline
added a commit
that referenced
this pull request
Oct 14, 2019
Contributor
Author
|
Backport: 7.x: f3991b9 |
tylersmalley
reviewed
Feb 6, 2020
| return { | ||
| push(event) { | ||
| eventRoller.addEvent(event); | ||
| server.log(['debug', LOGGING_TAG, KIBANA_MONITORING_LOGGING_TAG], 'Received Kibana Ops event data'); |
Member
There was a problem hiding this comment.
Wondering if this debug helps you folks, or you think it would be OK to remove. It generates a lot of noise when running in verbose.
Contributor
Author
There was a problem hiding this comment.
I think it would be okay. I don't know how useful it is to folks, but my gut says not that useful
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #33671
This is a PR that introduces a shim around Stack Monitoring server code for new platform use.
It resolves the following two migration steps: